Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting what views should be available from the Layout button #1900

Closed
laurent22 opened this issue Sep 26, 2019 · 4 comments
Closed
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements

Comments

@laurent22
Copy link
Owner

laurent22 commented Sep 26, 2019

The layout button toggles between Editor, Viewer and Split View. There should be an option to decide what mode should be available. For example, some users might only want the Editor and Viewer modes, but never need the Split View one.

To do so, a dropdown option named "Available layouts" should be added to the Config screen, with the following settings:

  • Editor / Viewer / Split View
  • Editor / Viewer
  • Editor / Split View
  • Viewer / Split View

And that option should be linked to the behaviour of the Layout button.

The config option should be added to models/Setting.js while the NOTE_VISIBLE_PANES_TOGGLE action should be modified to support this new option.

@laurent22 laurent22 added good first issue desktop All desktop platforms labels Sep 26, 2019
@pmielnik
Copy link

Hi! Do you still need help with this? If so I'd be glad to pick up this issue.

@laurent22
Copy link
Owner Author

Sure, please do.

@BackSeat
Copy link

BackSeat commented Oct 6, 2019

Hmm. Better still, I suggest, would be the option of multiple buttons, one per layout. The cycling/toggling feels a bit cumbersome. Ack that it's easy to stand here and chuck rocks: not my intention to be be negative.

@SubodhDahal
Copy link
Contributor

@laurent22 This issue doesn't seem to have been worked on in quite some time, so I created a solution for it and sent PR at #2028.

@lock lock bot locked and limited conversation to collaborators Nov 7, 2019
scoroi pushed a commit to scoroi/joplin that referenced this issue Nov 10, 2019
…e available from the Layout button (laurent22#2028)

* Added options for selecting layout

* Toggle through the layouts based on config

* Used redux state for getting layout settings

* Removed duplicated strings for layout options

* Moved option for selecting layouts to "View" menu
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

4 participants