Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to click any hyperlinks #10199

Closed
AlexNduta opened this issue Mar 25, 2024 · 9 comments · Fixed by #10547
Closed

Unable to click any hyperlinks #10199

AlexNduta opened this issue Mar 25, 2024 · 9 comments · Fixed by #10547
Assignees
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@AlexNduta
Copy link

Operating system

Linux

Joplin version

2.13.15(prod, linux)

Desktop version info

Joplin 2.13.15 (prod, linux)

Client ID: b004e148f5cb4b5599fec4870acef301
Sync Version: 3
Profile Version: 44
Keychain Supported: No

Current behaviour

I have two types of links on my notebooks:

  1. URLs I just copy-pasted randomly from a web page
  2. URL that I used the insert/Edit feature in Joplin

unfortunately, none of the links open up by default. I have to copy the link manually from the notebook and paste it in a browser.
NB: I am running on Debian 12 Bookworm. I highly doubt its a base OS issue.
image

This is a video of me demonstrating the issue. unless I copy and paste the link manually, I cannot open the link.
Screencast from 2024-03-25 08-24-28.webm

Expected behaviour

I am sure this feature was intended to work through a redirect.
I expected that, clicking the link would redirect me to my default webpage.

Logs

No response

@AlexNduta AlexNduta added the bug It's a bug label Mar 25, 2024
@laurent22
Copy link
Owner

Does it work in 2.14? I think this has been fixed

@AlexNduta
Copy link
Author

Just updated and still no changes. Update details below:

Joplin 2.14.20 (prod, linux)

Client ID: b004e148f5cb4b5599fec4870acef301
Sync Version: 3
Profile Version: 46
Keychain Supported: No

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Mar 25, 2024
@DarkFalc0n
Copy link
Contributor

Hey @AlexNduta, I just looked at your screen recording and I think the issue lies in the fact that you are using the Rich text editor. Clicking directly only works in markdown mode (in the right preview panel).
If you want to open links instantly in Rich Text mode instead, you can hold the CTRL (or equivalent) button while clicking.

@DarkFalc0n
Copy link
Contributor

DarkFalc0n commented Mar 25, 2024

Also, there are certain limitations to using the Rich Text Editor. If you decide to switch to Markdown editor, you can directly click the links in the right preview column

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Mar 25, 2024

If you want to open links instantly in Rich Text mode instead, you can hold the CTRL (or equivalent) button while clicking.

If it does work with ctrl, updating the tooltip text for links could be helpful. For example, Libreoffice Writer shows the following when hovering over a link:
screenshot: Libreoffice writer suggests ctrl-clicking on a link
Joplin, however, just shows the link:
screenshot: Joplin: Hovering over a link shows a tooltip with just the content of the link

@AlexNduta
Copy link
Author

Thanks @DarkFalc0n, It worked. I could have never figured that out. I think what @personalizedrefrigerator is suggesting sounds practical because its part of self-documentation.

@DarkFalc0n
Copy link
Contributor

DarkFalc0n commented Mar 25, 2024

I think the tooltip handling is done together for all types of editors (md and richtext). However, I think altering only the richtext editor hyperlink tooltips would be the way to go.

@243JohnM
Copy link

I have a similar problem with Joplin 2.14.20 on Windows. I posted this: https://discourse.joplinapp.org/t/web-links-in-joplin-windows-dont-work/37170

Someone told me about Ctrl + click on the link. That works, however, focus doesn't change to the web browser. Works fine on Android though!

@laurent22
Copy link
Owner

If it does work with ctrl, updating the tooltip text for links could be helpful. For example, Libreoffice Writer shows the following when hovering over a link:
screenshot: Libreoffice writer suggests ctrl-clicking on a link

For this issue we'd like to implement this then, if possible. If not possible maybe we can look at making the link clickable by default instead?

personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jun 5, 2024
This is a potential fix for laurent22#10199. This particular fix displays a
custom tooltip, in addition to the OS tooltip. The custom tooltip is
shown above the target element, while the OS tooltip (at least on my
Linux system) is shown below.

After this, I plan to work on a different fix that changes the content
of the OS tooltip, and changes it back before saving. This would be a
similar approach to laurent22#10359, except change the content in the rich text
editor, rather than in `turndown`. This has the advantage of also
working for HTML notes.
laurent22 pushed a commit that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment