Desktop, Cli: Fixes #8788: Work around WebDAV sync issues over ipv6 (#…

…9286)

packages/lib/BaseApplication.ts

@@ -26,6 +26,7 @@ import time from './time';
 import BaseSyncTarget from './BaseSyncTarget';
 const reduxSharedMiddleware = require('./components/shared/reduxSharedMiddleware');
 const os = require('os');
+import dns = require('dns');
 import fs = require('fs-extra');
 const EventEmitter = require('events');
 const syswidecas = require('./vendor/syswide-cas');
@@ -171,6 +172,13 @@ export default class BaseApplication {
 			this.showStackTraces_ = true;
 		}
 
+		// Work around issues with ipv6 resolution -- default to ipv4first.
+		// (possibly incorrect URL serialization see https://github.com/mswjs/msw/issues/1388#issuecomment-1241180921).
+		// See also https://github.com/node-fetch/node-fetch/issues/1624#issuecomment-1407717012
+		if (flags.matched.allowOverridingDnsResultOrder) {
+			dns.setDefaultResultOrder('ipv4first');
+		}
+
 		return {
 			matched: flags.matched,
 			argv: flags.argv,

packages/lib/utils/processStartFlags.ts

@@ -11,6 +11,7 @@ export interface MatchedStartFlags {
 	isSafeMode?: boolean;
 	showStackTraces?: boolean;
 	logLevel?: LogLevel;
+	allowOverridingDnsResultOrder?: boolean;
 	devPlugins?: string[];
 }
 
@@ -63,6 +64,14 @@ const processStartFlags = async (argv: string[], setDefaults = true) => {
 			continue;
 		}
 
+		if (arg.startsWith('--dns-result-order=')) {
+			matched.allowOverridingDnsResultOrder = false;
+
+			// Handled by Electron/NodeJS (and indicates we shouldn't override this ourselves).
+			argv.splice(0, 1);
+			continue;
+		}
+
 		if (arg === '--debug') {
 			// Currently only handled by ElectronAppWrapper (isDebugMode property)
 			argv.splice(0, 1);
@@ -168,6 +177,7 @@ const processStartFlags = async (argv: string[], setDefaults = true) => {
 		if (!matched.logLevel) matched.logLevel = Logger.LEVEL_INFO;
 		if (!matched.env) matched.env = 'prod';
 		if (!matched.devPlugins) matched.devPlugins = [];
+		matched.allowOverridingDnsResultOrder ??= true;
 	}
 
 	return {