Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopping List Challenge #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Shopping List Challenge #4

wants to merge 1 commit into from

Conversation

kklumpp13
Copy link

Submission for the apprenticeship challenge. Thank you for reviewing!

@superchris
Copy link
Member

Krystal,

Here are some impressions after reviewing your submission. It was easy to get your application up and running. It was one of the most visually appealing submissions we received, nice work on that. It was great to see that adding categories and adding things to buy worked well. Next, we'd like to see if you can take this application a bit further. We'd love it if you could have items have separate form inputs for price, name, and SKU. Also, while looking at your code it was great to see a Category component, but seeing a Note component was a bit confusing. As developers, we love code that is named well and tells us what it does. It might be great to name this component Item or something similar.

If you'd like to continue work on this application and have us review it again, we'd be happy to do. We've selected a few candidates for interviews, and based on the outcome of these we may or may not be bringing in more candidates to interview for the first apprentice pair. Regardless, we expect to hire a second pair in the next month or two and would be happy to consider your submission again then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants