Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben Barnett Initial Pull Request #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

univthink
Copy link

This is my first quick attempt

@superchris
Copy link
Member

Ben,

Here are some impressions after reviewing your submission. It appears you started with a React Todo example and added some prompts to gather the name, SKU, and price. While starting from an example app is a great way to learn, we're hoping you can take this app a bit further. We'd really like to see each item have separate form fields for name, price, and SKU. Also, at a code level we love to see the components broken out into separate files in a way that makes it easy to understand what each one does. ShoppingList and Item might be good names for components, for example.

If you'd like to make some changes and have us review again, we'd be happy to do that. We've selected a few candidates for initial interviews, and base on the outcome of these we may or may not need to do additional interviews for the first pair of apprentices. However, we expect to hire a second pair in a month or two and would be happy to reconsider your submission then.

@univthink
Copy link
Author

Thanks for the response! I can certainly get something resubmitted within
a few weeks. Sorry for using an open source app to start, I was just
feeling the time pinch.

Thanks again for your time and advice moving forward,

Ben Barnett | UnivThink.com
On Apr 12, 2016 7:19 PM, "Chris Nelson" [email protected] wrote:

Ben,

Here are some impressions after reviewing your submission. It appears you
started with a React Todo example and added some prompts to gather the
name, SKU, and price. While starting from an example app is a great way to
learn, we're hoping you can take this app a bit further. We'd really like
to see each item have separate form fields for name, price, and SKU. Also,
at a code level we love to see the components broken out into separate
files in a way that makes it easy to understand what each one does.
ShoppingList and Item might be good names for components, for example.

If you'd like to make some changes and have us review again, we'd be happy
to do that. We've selected a few candidates for initial interviews, and
base on the outcome of these we may or may not need to do additional
interviews for the first pair of apprentices. However, we expect to hire a
second pair in a month or two and would be happy to reconsider your
submission then.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)

@univthink
Copy link
Author

Hi Chris,

Lisa from Cincy Code IT mentioned your name today, and it made me think of this interaction. I wanted to thank you once again for the feedback, and to say I hope to become re-acquainted at one of Gaslight's JavaScript meetups.

It's an awesome thing that you guys do, keep on movin'!

Ben Barnett. Director of Ideas. Think-Tank

+1 (513) 545- 3118 | benjamin @ UniversallyThinking.com

@univthink | www.UniversallyThinking.com | Schedule a Meeting

---- On Tue, 12 Apr 2016 19:18:31 -0400 Chris Nelson <[email protected]>wrote ----

Ben,

Here are some impressions after reviewing your submission. It appears you started with a React Todo example and added some prompts to gather the name, SKU, and price. While starting from an example app is a great way to learn, we're hoping you can take this app a bit further. We'd really like to see each item have separate form fields for name, price, and SKU. Also, at a code level we love to see the components broken out into separate files in a way that makes it easy to understand what each one does. ShoppingList and Item might be good names for components, for example.

If you'd like to make some changes and have us review again, we'd be happy to do that. We've selected a few candidates for initial interviews, and base on the outcome of these we may or may not need to do additional interviews for the first pair of apprentices. However, we expect to hire a second pair in a month or two and would be happy to reconsider your submission then.

You are receiving this because you authored the thread.

Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants