-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ben Barnett Initial Pull Request #1
base: master
Are you sure you want to change the base?
Conversation
Ben, Here are some impressions after reviewing your submission. It appears you started with a React Todo example and added some prompts to gather the name, SKU, and price. While starting from an example app is a great way to learn, we're hoping you can take this app a bit further. We'd really like to see each item have separate form fields for name, price, and SKU. Also, at a code level we love to see the components broken out into separate files in a way that makes it easy to understand what each one does. ShoppingList and Item might be good names for components, for example. If you'd like to make some changes and have us review again, we'd be happy to do that. We've selected a few candidates for initial interviews, and base on the outcome of these we may or may not need to do additional interviews for the first pair of apprentices. However, we expect to hire a second pair in a month or two and would be happy to reconsider your submission then. |
Thanks for the response! I can certainly get something resubmitted within Thanks again for your time and advice moving forward, Ben Barnett | UnivThink.com
|
Hi Chris, Lisa from Cincy Code IT mentioned your name today, and it made me think of this interaction. I wanted to thank you once again for the feedback, and to say I hope to become re-acquainted at one of Gaslight's JavaScript meetups. It's an awesome thing that you guys do, keep on movin'! Ben Barnett. Director of Ideas. Think-Tank +1 (513) 545- 3118 | benjamin @ UniversallyThinking.com @univthink | www.UniversallyThinking.com | Schedule a Meeting ---- On Tue, 12 Apr 2016 19:18:31 -0400 Chris Nelson <[email protected]>wrote ---- Ben, Here are some impressions after reviewing your submission. It appears you started with a React Todo example and added some prompts to gather the name, SKU, and price. While starting from an example app is a great way to learn, we're hoping you can take this app a bit further. We'd really like to see each item have separate form fields for name, price, and SKU. Also, at a code level we love to see the components broken out into separate files in a way that makes it easy to understand what each one does. ShoppingList and Item might be good names for components, for example. If you'd like to make some changes and have us review again, we'd be happy to do that. We've selected a few candidates for initial interviews, and base on the outcome of these we may or may not need to do additional interviews for the first pair of apprentices. However, we expect to hire a second pair in a month or two and would be happy to reconsider your submission then. — You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub |
This is my first quick attempt