Add team_members data source #55
Conversation
Adds team_members data source which allows the lookup of a list of team members by their email and returns a list of member objects. The data source also includes an optional field "ignore_missing" which allows for the graceful filtering of members that return an error. This will help in the management of members who are added through SSO facilities and not the team_member Terraform resource. Adds: - launchdarkly_team_members data source
There was a problem hiding this comment.
Hi @patrickmarabeas,
Thanks for submitting this, we are always grateful of outside contributions. I had one suggestion that should be addressed before releasing this data source. Let me know if you don't have time to make the change so I can get someone from our side to take over.
Thanks,
Henry
| if emails, ok := d.Get(EMAILS).([]interface{}); ok && len(emails) > 0 { | ||
| expectedCount = len(emails) | ||
| for _, memberEmail := range emails { | ||
| member, err := getTeamMemberByEmail(client, fmt.Sprintf("%s", memberEmail)) |
There was a problem hiding this comment.
It seems getTeamMemberByEmail actually just makes an API call to get all team members and then filters the response to return the single member. In this case it would be significantly more efficient to just call client.ld.TeamMembersApi.GetMembers once and then filter the response based on the provided email list.
Probably the best course of action would be to refactor the API call into a new function called getTeamMembers that can be used in getTeamMemberByEmail and in your data source.
|
Hi @patrickmarabeas, We've added a I know it's been a while since the initial request, but please let us know if that works for you. |
Adds team_members data source which allows the lookup of a list of team
members by their email and returns a list of member objects. The data
source also includes an optional field "ignore_missing" which allows
for the graceful filtering of members that return an error. This will
help in the management of members who are added through SSO facilities
and not the team_member Terraform resource.
Adds: