[ch88739] Fix decoding of multiple events in a single chunk #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #88739: Rust SDK - get passing IH again with eventsource 0.4.0. |
Oops
hroederld
approved these changes
Mar 8, 2021
samstokes
added a commit
to mraerino/rust-eventsource-client
that referenced
this pull request
May 16, 2021
…)' to this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the SSE decoder again to fix a nasty bug that seemed to be occurring intermittently during IH tests (and in any case was reproducible). If two events occurred within a single chunk, we would drop one, which is unfortunate. This may have been introduced during the last rewrite (#3).
I also tried hard to simplify down the logic and remove some conditionals that didn't need to be there, so hopefully the result is a little more readable than what came before.