Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch83910] Rewrite decoder to fix some decoding bugs #3

Merged
merged 17 commits into from
Sep 3, 2020
Merged

[ch83910] Rewrite decoder to fix some decoding bugs #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1181f84
add split chunk test
hroederld Jul 20, 2020
c9a1d32
add multiple data lines test
hroederld Jul 20, 2020
5b7bd27
fix formatting and add a NotReady so errors show up in CI
samstokes Jul 20, 2020
a853cc0
Rewrite chunk-to-line decoding to handle line terminators _within_ chunk
samstokes Aug 12, 2020
c9fdd78
tweak test delay handling, add another test case
samstokes Aug 12, 2020
bb4d202
Append subsequent values for the same field instead of replacing
samstokes Aug 12, 2020
0908167
remove unnecessary mut
samstokes Aug 12, 2020
1cc8cae
clean up trace logging a bit
samstokes Aug 12, 2020
685146b
handle incomplete chunks in middle of stream
samstokes Aug 12, 2020
6f30d2f
add env_logger in example script and mention logging in DEVELOPING.md
samstokes Aug 13, 2020
75fb7af
get rid of some unwrap() for readability
samstokes Aug 13, 2020
0a932c3
remove placeholder test
samstokes Aug 13, 2020
cee673e
less confusing ordering
samstokes Aug 13, 2020
98044c4
only strip a single initial space
samstokes Aug 13, 2020
8b2dd42
handle lines with no colons correctly
samstokes Aug 14, 2020
2a1a2a8
jiggle around test cases instead of having one gigantic test function
samstokes Aug 14, 2020
0883ae7
add CH link for line terminator TODO
samstokes Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ reqwest = "0.9.11"
tokio-timer = "0.2.11"

[dev-dependencies]
env_logger = "0.7.1"
maplit = "1.0.1"
simplelog = "0.5.3"
tokio = "0.1.16"
9 changes: 9 additions & 0 deletions DEVELOPING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Guide to developing rust-eventsource-client

Incomplete.

## Get detailed logging

eventsource-client uses the standard [log crate](https://crates.io/crates/log) for logging. It will log additional detail about the protocol implementation at `trace` level.

e.g. if using [env_logger](https://crates.io/crates/env_logger) (as the example script does), set `RUST_LOG=eventsource_client=trace`.
2 changes: 2 additions & 0 deletions examples/tail.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ use futures::{future::Future, lazy, stream::Stream};
use eventsource_client as es;

fn main() -> Result<(), es::Error> {
env_logger::init();

let args: Vec<String> = env::args().collect();

if args.len() != 3 {
Expand Down
Loading