[ch77330] review tests #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samstokes
added a commit
that referenced
this pull request
Sep 3, 2020
This fixes a few bugs and places we weren't quite compliant with the spec: * the handling for lines split across chunks wasn't quite right and could drop lines if that happened more than once in a stream. * we were stripping all leading spaces from field values, instead of just the first leading space. multiple values for the same field would overwrite (now they concatenate instead) * a line without a colon was treated as an error (now it treats the whole line as the field name, with an empty field value) Closes #2 (includes commits from that PR, which included tests that discovered some of these bugs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two tests that I would expect to pass. Maybe I have misunderstood how the implementation works though and this is at the wrong layer IDK.
The first test validates dispatch when messages are split at the TCP level without a newline at the end.
The second test validates (although LD does not use this feature)
datafields being split across events in a single message.