feat(components): add Modal and ModalOverlay
#1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f02b33a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +978 B (+1%) Total Size: 190 kB
ℹ️ View Unchanged
|
apucacao
approved these changes
Jan 30, 2024
apucacao
reviewed
Jan 30, 2024
Niznikr
commented
Jan 30, 2024
Comment on lines
+36
to
+66
| <DialogTrigger> | ||
| <Button>Trigger</Button> | ||
| <ModalOverlay> | ||
| <Modal {...args}> | ||
| <Dialog> | ||
| {({ close }) => ( | ||
| <> | ||
| <div slot="header"> | ||
| {destructive && ( | ||
| <Icon name="warning" size="medium" fill="var(--lp-color-fill-feedback-warning)" /> | ||
| )} | ||
| <Heading slot="title">Title</Heading> | ||
| <IconButton | ||
| aria-label="close" | ||
| icon="cancel" | ||
| size="small" | ||
| variant="minimal" | ||
| onPress={close} | ||
| /> | ||
| </div> | ||
| <div slot="body">Body text</div> | ||
| <div slot="footer"> | ||
| <Button onPress={close}>Cancel</Button> | ||
| <Button variant="primary">Confirm</Button> | ||
| </div> | ||
| </> | ||
| )} | ||
| </Dialog> | ||
| </Modal> | ||
| </ModalOverlay> | ||
| </DialogTrigger> |
There was a problem hiding this comment.
Using slot attributes as targets for content styling to avoid having to create/maintain decoration divs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
Modalwith variantsdefaultanddrawersince functionally they are the same.Screenshots (if appropriate):
modals.mov