feat: Add support for client-side prerequisite events. #112
Conversation
src/index.js
Outdated
| @@ -320,6 +321,12 @@ function initialize(env, context, specifiedOptions, platform, extraOptionDefs) { | |||
| } | |||
|
|
|||
| if (sendEvent) { | |||
| // An event will be send for each of these by virtue of sending events for all flags. | |||
| if (!allFlags) { | |||
There was a problem hiding this comment.
So, I am not 100% sure there is a good answer here. For sure if you are sending events for all flags, then the prereq will have an event if it was visible to the client.
There was a problem hiding this comment.
This comment is still relevant github. I just corrected part of the line. >.<
kinyoklion
force-pushed
the
rlamb/sdk-685/client-side-prerequisites
branch
from
7a0437d to
39a1155
Compare
| @@ -552,7 +552,7 @@ declare module 'launchdarkly-js-sdk-common' { | |||
|
|
|||
| /** | |||
| * Describes the reason that a flag evaluation produced a particular value. This is | |||
| * part of the {@link LDEvaluationDetail} object returned by {@link LDClient.variationDetail]]. | |||
There was a problem hiding this comment.
Noticed this when working on the docs for node-client-sdk. So a good chance to just fix that link.
| @@ -1,3 +1,4 @@ | |||
| // @ts-nocheck | |||
There was a problem hiding this comment.
Added this ts-nocheck as typescript checking in eslint isn't happy in this file. Nothing changed, but the typescript version was updated. Basically just affects the IDE.
…launchdarkly/js-sdk-common into rlamb/sdk-685/client-side-prerequisites
src/index.js
Outdated
| options, | ||
| diagnosticId | ||
| ) | ||
| platform, |
There was a problem hiding this comment.
There are a few formatting changes from prettier.
🤖 I have created a release *beep* *boop* --- ## [5.4.0](5.3.0...5.4.0) (2024-10-18) ### Features * Add support for client-side prerequisite events. ([#112](#112)) ([9d1708b](9d1708b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.