-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare 2.17.2 release #206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pin Node version to 11.10.1 due to Jest problem
add support for optional trackReasons flag for experimentation
replace rm with rimraf in react wrapper build
add azure pipeline
coerce user attributes into strings when necessary
asyncify tests, simplify HTTP mocking, general cleanup
generate keys for anonymous users
use js-sdk-common 3.1.2 and loosen our other dependency
# Conflicts: # package-lock.json # package.json
enable diagnostic events in JS SDK
standardize linting
update js-sdk-common for content type bugfix; update some dev dependencies
remove unsafe usage of hasOwnProperty
bwoskow-ld
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.17.2] - 2020-03-18
Fixed:
application/json, application/json; charset=utf8
. It is invalid to have multiple Content-Type values in a response and the LaunchDarkly service does not do this, but an improperly configured proxy/gateway might add such a header. Now the SDK will tolerate a value like this as long as it starts withapplication/json
. (#205)Object.hasOwnProperty
which could have caused an error if a feature flag hadhasOwnProperty
as its flag key.