Prevent resetMocks: true from clearing mock implementations #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldfallen
requested review from
kinyoklion,
yusinto and
louis-launchdarkly
as code owners
|
Thank you for submitting this PR. We will review and provide an update soon. |
yusinto
requested changes
Jun 27, 2023
| mockWithLDConsumer.mockImplementation(() => (children: any) => children) | ||
| mockWithLDProvider.mockImplementation(() => (children: any) => children) | ||
| /* eslint-enable @typescript-eslint/no-explicit-any */ | ||
| export const setupMocks = () => { |
There was a problem hiding this comment.
To be consistent with resetLDMocks, can you please rename this to setupLDMocks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
If a team uses
resetMocks: truein their jest config then the mocked functions oflaunchdarkly-react-client-sdkwill return undefined during test execution.To allow teams using
resetMocksto use this package I have pulled the mock implementations into asetupMocksfunction that can be called inbeforeEach.I haven't updated the documentation to explain this usecase, I'd value feedback on where / how to do that.