address memory leak issue with regards to NSURLSession #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @jimmaye . We will review it shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I submitted another PR earlier to the Launch Darkly iOS SDK, this is kinda similar to this PR, although I now save a strong reference to the
NSURLSessionobject, and use the ephemeral session configuration, since I assume caching etc. is not really needed for the operations performed.I've also inserted a cleanup of the session each time
openandcloseis executed to get rid of any leaks possible (they might be small and/or inferior, but our app still get's punished by iOS for them :-) )For reference, here's the other issue+PR: launchdarkly/ios-client-sdk#97