Fix semaphore issues #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the stream URL
* Fix RequestManager mock in LDPollingManagerTest * Update schemes * Update to 2.2.1 * Update XCode version * Remove use of shared instance * Fix for deletion array count * Update to version 2.3.0 * Revert test changes * Revert "Revert test changes" * Update README markdown * Add Platform to README * Update Readme to reflect carthage
* Remove pollingCount * Introduce semaphores to make synchronous api calls * Remove race condition for creationDate
Fix Semaphore Issues
|
👍 |
markpokornycos
added a commit
that referenced
this pull request
Aug 15, 2018
* adds summary event tests with empty and nil tracker * synchronize tracker access * adds guard for nil flagKey to initSummaryEvent * adds nil summary event guard to DataManager createSummaryEvent * adds guard for empty flagKey to FlagConfigTracker * removes unused defaultValue from FlagCounter logRequest * adds guard for nil reported value in FlagCounter’s logRequest * adds nil reportedValue handling to LDFlagValueCounter * advance version documents * removes access to LDFlagConfigTracker flagCounters Too much chance to misuse it * removes flagCounters from public access * move selected items outside of synchronized blocks
torchhound
pushed a commit
that referenced
this pull request
May 27, 2020
Fix FlagStore to synchronize reads with writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the semaphore bug which was resulting in multiple api calls being generated simultaneously after the time specified in
kConnectionTimeout.