Fix config flags in user model #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there is a test that needs to be modified now that we are not sending the config object in the event: https://circleci.com/gh/launchdarkly/ios-client/72 (unless the CircleCI bug with exit code 65 is causing this failure, but it seems like there is a real test failure, and it makes sense that changing the data in the event would need a test case change too.) Or, maybe I'm misreading this failing test. It looks like the failing test is asserting that after creating 2 events, there are 2 events in the resulting JSON? |
|
Just needed to restart the tests once. It was an internal CircleCI issue. |
|
lgtm |
markpokornycos
added a commit
that referenced
this pull request
Mar 8, 2019
* renames schemes and targets to LaunchDarkly * renames test target and headers to LaunchDarkly * renames code and test folders to LaunchDarkly * renames xcode project to LaunchDarkly * renames workspace to LaunchDarkly * renames modules and sets Catamorphic Co as license holder in block header comment * renames podfile workspace and targets to LaunchDarkly * renames Jazzy components to LaunchDarkly * replaces outdated variable_name rule with identifier_name to clear swiftlint warnings * renames workspace and scheme to LaunchDarkly in circleCI * installs CocoaPods 1.6.0 * installs DarklyEventSource 4.0.1 * installs Quick 7.3.4 and Nimble 1.3.4 * installs SwiftLint 0.30.1 * Add instructions to integrate without a package manager (#57) * Replaces onServerUnavailable with ErrorObserver (#58) * Adds new logging around variationAndSource (#59) * Install keys to model objects (#60) * Adds Automated Tests for missing coverage (#61) * Decompress Blocks (#62) * Refine flag version handling (#63) * sets beta 3 version and updates public documents * Add Platform Names to non-iOS frameworks (#65) * renames all schemes, targets, and non-iOS products to include the platform * updates changelog and instructions for non-iOS platforms
markpokornycos
added a commit
that referenced
this pull request
Mar 8, 2019
* renames schemes and targets to LaunchDarkly * renames test target and headers to LaunchDarkly * renames code and test folders to LaunchDarkly * renames xcode project to LaunchDarkly * renames workspace to LaunchDarkly * renames modules and sets Catamorphic Co as license holder in block header comment * renames podfile workspace and targets to LaunchDarkly * renames Jazzy components to LaunchDarkly * replaces outdated variable_name rule with identifier_name to clear swiftlint warnings * renames workspace and scheme to LaunchDarkly in circleCI * installs CocoaPods 1.6.0 * installs DarklyEventSource 4.0.1 * installs Quick 7.3.4 and Nimble 1.3.4 * installs SwiftLint 0.30.1 * Add instructions to integrate without a package manager (#57) * Replaces onServerUnavailable with ErrorObserver (#58) * Adds new logging around variationAndSource (#59) * Install keys to model objects (#60) * Adds Automated Tests for missing coverage (#61) * Decompress Blocks (#62) * Refine flag version handling (#63) * sets beta 3 version and updates public documents * Add Platform Names to non-iOS frameworks (#65) * renames all schemes, targets, and non-iOS products to include the platform * updates changelog and instructions for non-iOS platforms * updates items for public release * updates pods project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkodumal Could you please review the changes before I merge.