Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warnings for Boolean Values #60

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Fix Warnings for Boolean Values #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Darkly.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@
CC36AA8C1B6D5FED008200F1 /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 0640;
LastUpgradeCheck = 0730;
ORGANIZATIONNAME = Darkly;
TargetAttributes = {
23AA1AB51B721E3E00FE6A00 = {
Expand Down Expand Up @@ -847,6 +847,7 @@
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_DYNAMIC_NO_PIC = NO;
GCC_NO_COMMON_BLOCKS = YES;
Expand Down Expand Up @@ -970,6 +971,7 @@
);
INFOPLIST_FILE = DarklyTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "Darkly.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Debug;
Expand All @@ -987,6 +989,7 @@
GCC_PREFIX_HEADER = "Darkly/Darkly-Prefix.pch";
INFOPLIST_FILE = DarklyTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "Darkly.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Release;
Expand Down
4 changes: 2 additions & 2 deletions Darkly/LDEventModel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ - (id)initWithDictionary:(NSDictionary *)dictionary {
self.kind = [dictionary objectForKey: kKindKey];
NSNumber *creationDateValue = [dictionary objectForKey:kCreationDateKey];
self.creationDate = [creationDateValue longValue];
self.featureKeyValue = [dictionary objectForKey: kFeatureKeyValueServerKey];
self.isDefault = [dictionary objectForKey: kIsDefaultServerKey];
self.featureKeyValue = [[dictionary objectForKey: kFeatureKeyValueServerKey] boolValue];
self.isDefault = [[dictionary objectForKey: kIsDefaultServerKey] boolValue];
self.user = [[LDUserModel alloc] initWithDictionary:[dictionary objectForKey:kUserKey]];
}
return self;
Expand Down
2 changes: 1 addition & 1 deletion Darkly/LDUserModel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ - (id)initWithDictionary:(NSDictionary *)dictionary {
self.custom = [dictionary objectForKey: kCustomKey];
self.device = [dictionary objectForKey: kDeviceKey];
self.os = [dictionary objectForKey: kOsKey];
self.anonymous = [dictionary objectForKey: kAnonymousKey];
self.anonymous = [[dictionary objectForKey: kAnonymousKey] boolValue];
self.config = [[LDFlagConfigModel alloc] initWithDictionary:[dictionary objectForKey:kConfigKey]];
if ([dictionary objectForKey:kUpdatedAtKey]) {
self.updatedAt = [dictionary objectForKey:kUpdatedAtKey];
Expand Down
2 changes: 1 addition & 1 deletion DarklyTests/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>Darkly.$(PRODUCT_NAME:rfc1034identifier)</string>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
Expand Down