Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Install correct mint binary #415

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: Install correct mint binary #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/ci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ runs:
- name: Install mint
shell: bash
run: |
brew tap mint-lang/mint-lang
brew install mint-lang libressl
brew install mint

- name: Install cocoapods
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions LaunchDarkly/LaunchDarkly/LDClientVariation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ extension LDClient {
// recurse on prerequisites to emulate prereq evaluations occurring with desirable side effects such as events for prereqs
_ = variationDetailInternal(prereqFlagKey, LDValue.null, needsReason: needsReason, methodName: methodName)
}

if featureFlag.value == .null {
result = LDEvaluationDetail(value: defaultValue, variationIndex: featureFlag.variation, reason: featureFlag.reason)
} else {
Expand All @@ -193,7 +193,7 @@ extension LDClient {
os_log("%s Unknown feature flag %s; returning default value", log: config.logger, type: .debug, typeName(and: #function), flagKey.description)
result = LDEvaluationDetail(value: defaultValue, variationIndex: nil, reason: ["kind": "ERROR", "errorKind": "FLAG_NOT_FOUND"])
}

eventReporter.recordFlagEvaluationEvents(flagKey: flagKey,
value: result.value.toLDValue(),
defaultValue: defaultValue.toLDValue(),
Expand Down
2 changes: 1 addition & 1 deletion LaunchDarkly/LaunchDarkly/Models/FeatureFlag/FlagRequestTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ final class FlagCounter: Encodable {
private(set) var defaultValue: LDValue
private(set) var flagValueCounters: [CounterKey: CounterValue] = [:]
private(set) var contextKinds: Set<String> = Set()

init(defaultValue: LDValue) {
// default value follows a "first one wins" approach where the first evaluation for a flag key sets the default value for the summary events
self.defaultValue = defaultValue
Expand Down
2 changes: 1 addition & 1 deletion ...kly/LaunchDarklyTests/Models/FeatureFlag/FlagRequestTracking/FlagRequestTrackerSpec.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final class FlagRequestTrackerSpec: XCTestCase {
counter.trackRequest(reportedValue: false, featureFlag: flag, context: LDContext.stub())
XCTAssertEqual(flagRequestTracker.flagCounters["bool-flag"], counter)
}

func testTrackRequestSameFlagKeyDifferentDefault() {
let flag = FeatureFlag(flagKey: "bool-flag", variation: 1, version: 5, flagVersion: 2)
var flagRequestTracker = FlagRequestTracker(logger: OSLog(subsystem: "com.launchdarkly", category: "tests"))
Expand Down
Loading