Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure anonymous context is valid #336

Merged
merged 4 commits into from
Feb 9, 2024
Merged

fix: Ensure anonymous context is valid #336

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8330b0f
fix: Ensure anonymous context is valid
keelerm84 Feb 8, 2024
b42cf33
Extend sleep like v9
keelerm84 Feb 9, 2024
b128d79
use status-timeout
keelerm84 Feb 9, 2024
34f808a
Increase to 2 minutes
keelerm84 Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/ci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ runs:
shell: bash
# Add a brief sleep here to ensure the test service is ready to receive
# requests
run: sleep 5 && make run-contract-tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the new argument I added to the sdk-test-harness

-status-timeout 15 or something.

run: sleep 10 && make run-contract-tests
1 change: 1 addition & 0 deletions LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public struct LDContext: Encodable, Equatable {

init() {
self.init(canonicalizedKey: LDContext.defaultKey(kind: Kind.user))
self.key = self.canonicalizedKey
}

struct Meta: Codable {
Expand Down
Loading