-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.4.0 #239
Merged
Merged
Release 5.4.0 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Identify method
…tream close listener
…ange Changed lastSuccessfulConnection to lastKnownFlagValidity, added on s…
* Added 4.2.1 changes including Dictionary fix and test and eventsource version bump * Added Carthage build files * Added attribution to CHANGELOG
* Initial Evaluation Reasons prototype * Changed evaluationReasons to reasons, fixed mangled question mark in url query parameters * Added errorKinds * Added reason to debug events * Changed reason nil handling in events * Removed unnecessary private functions, removed event nil coalesce * Event change for reason nil * Removed if in Event for reason nil, added guard let NSNull for dictionary in Events * Added reason null to normal variation calls * Testing alternate reason null set * Change Event comparison code to add reason * Removed reason from event dictionary matches * Removed Event Equatable reason and changed Event Dictionary matches * Explicitly set featureflag reason property to nil when not send feature event for variationDetail * Fixed DeprecatedCacheModel unit tests, added v6 model tests, added variation detail unit tests, changed event reason nil check * Added variationDetail to objective c, fixed cache converter unit tests, deprecated variationAndSource * Added new files to correct target membership * Simplify featureflag reason nil check * Removed unnecessary comments, deprecated objc variationAndSource * Improved doc strings, cut down on variation doc string repetition, added reason tests for Event and EventReporter, added EvaluationDetail generic * Added ObjCEvaluationDetail to correct target membership * Differentiated objc evaluation detail return type, change reason constant in unit tests * Removed Optional value on fallback variation * Added Event test for reason false but flag reason present, cleaned up objc doc strings, changed optional types in objc evaluation detail
* Added trackReasons and metricValue as well as doc and unit tests * Added unit tests for reason false track reason true, added objc track without metricValue, changed and trackReason to or trackReason * Added explicit event store reason test * Fixed objc track comment * Updated reason to includeReason for clarity * Explicitly check both feature and debug events
* Updated ios-eventsource to 4.1.0, updated version strings * Added sentence about iOS SDK compat to CHANGELOG * pod repo update to get new eventsource version
* Fixed change listener not firing when only value changes * Fixed a unit test variable name typo * Cast flag value to dictionary instead of string, improved unit test * Remove debug printout, remove unnecessary parameter
* Added newStart function, updated README, podspec, and CHANGELOG * Changed newStart to startAwaitingFlags * Added doc strings for startAwaitingFlags and deprecated start * Added cocoapods lib lint flag to ignore depracted API usage in ObjCLDClient, added startAwaitingFlags to ObjC * Fixed alow to allow, changed startAwaitFlags to startCompleteWhenFlagsReceived, added unit tests for startCompleteWhenFlagsReceived * Updated deprecation message to startCompleteWhenFlagsReceived
* Added X-LaunchDarkly-Payload-ID header to event request headers, add string length check on LD payload ID header in header unit tests * Added CHANGELOG Added entry for event request header * Added UUID generation to DarklyService so it's regenerated on each request
* Added single retry attempt to event post * Added payloadId to the correct point to maintain value between retries, retry on error * reportSyncComplete on 2nd error, always log on event post error, add 1 second delay with log on event post retry * Added 1 second delay to retry event post * async'd event post to prevent blocking main thread on retry sleep * Increased event test waitUntil timeout to 10 seconds
* Added isInitialized method and unit tests * Fix unit tests, stop double testContext.start * PR feedback * Remove returns doc
torchhound
approved these changes
Feb 26, 2021
bwoskow-ld
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.4.0] - 2021-02-26
Added
alias
method toLDClient
. This can be used to associate two user objects for analytics purposes with an alias event.autoAliasingOptOut
configuration option. This can be used to control the new automatic aliasing behavior of theidentify
method; by settingautoAliasingOptOut
to true,identify
will not automatically generate alias events.isInitialized
property toLDClient
. Unless the client has been set offline, this property's value isfalse
until the client receives an initial set of flag values from the LaunchDarkly service. If the client is offline, the value will betrue
after initialization.Changed
identify
method will now automatically generate an alias event when switching from an anonymous to a known user. This event associates the two users for analytics purposes as they most likely represent a single person.Fixed
DiagnosticReporter
implementation, which has been reworked to address these issues. Thanks to @provanandparanjape for one such report (#238).