Prepare 4.3.0 release #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* installs new deviceModel into EnvironmentReporter and renames old deviceModel to deviceType * use CwSysCtl for macos model
Fix for concurrency bug in FlagStore
Prepare Version 4.1.1
…formation to struct
…and wasOnline is false
Add Identify method
…tream close listener
…ange Changed lastSuccessfulConnection to lastKnownFlagValidity, added on s…
* Added 4.2.1 changes including Dictionary fix and test and eventsource version bump * Added Carthage build files * Added attribution to CHANGELOG
* Initial Evaluation Reasons prototype * Changed evaluationReasons to reasons, fixed mangled question mark in url query parameters * Added errorKinds * Added reason to debug events * Changed reason nil handling in events * Removed unnecessary private functions, removed event nil coalesce * Event change for reason nil * Removed if in Event for reason nil, added guard let NSNull for dictionary in Events * Added reason null to normal variation calls * Testing alternate reason null set * Change Event comparison code to add reason * Removed reason from event dictionary matches * Removed Event Equatable reason and changed Event Dictionary matches * Explicitly set featureflag reason property to nil when not send feature event for variationDetail * Fixed DeprecatedCacheModel unit tests, added v6 model tests, added variation detail unit tests, changed event reason nil check * Added variationDetail to objective c, fixed cache converter unit tests, deprecated variationAndSource * Added new files to correct target membership * Simplify featureflag reason nil check * Removed unnecessary comments, deprecated objc variationAndSource * Improved doc strings, cut down on variation doc string repetition, added reason tests for Event and EventReporter, added EvaluationDetail generic * Added ObjCEvaluationDetail to correct target membership * Differentiated objc evaluation detail return type, change reason constant in unit tests * Removed Optional value on fallback variation * Added Event test for reason false but flag reason present, cleaned up objc doc strings, changed optional types in objc evaluation detail
* Added trackReasons and metricValue as well as doc and unit tests * Added unit tests for reason false track reason true, added objc track without metricValue, changed and trackReason to or trackReason * Added explicit event store reason test * Fixed objc track comment * Updated reason to includeReason for clarity * Explicitly check both feature and debug events
gwhelanLD
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Evaluation Reasons Issue
Changelog
[4.3.0] - 2019-12-3
Added
variationDetailwhich returns an Evaluation Reason giving developers greater insight into why a value was returned.trackmethod now supports an additionalmetricValueparameter.