Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 4.2.1 release #198

Merged
merged 72 commits into from
Nov 15, 2019
Merged

Prepare 4.2.1 release #198

merged 72 commits into from
Nov 15, 2019

Conversation

torchhound
Copy link
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

(Thanks, cswelin!)

(#197)

Describe the solution you've provided

Changed

  • Updated to ios-eventsource version 4.0.3. This appends a platform name to bundle identifiers.

Fixed

  • Comparing two nil objects of type [String: Any]? no longer causes a crash.

markpokornycos and others added 30 commits May 17, 2019 08:14
@markpokornycos
Changes user-device to device model identifier (#75)
abe59a0 
* installs new deviceModel into EnvironmentReporter and renames old deviceModel to deviceType

* use CwSysCtl for macos model
@torchhound
Replaced entire flag store ff array instead of in place manipulation
a0ed7a0
@torchhound
Updated CHANGELOG and bumped version number
41572d9
@torchhound
Added correct copy behavior to FlagStore delete and update
706768d
@torchhound
Merge pull request #76 from launchdarkly/jc/concurrency-fix
1a924a0 
Fix for concurrency bug in FlagStore
@torchhound
Improved CHANGELOG entry for 4.0.1
a7fc8c6
@torchhound
Changed version to 4.1.0, updated CHANGELOG
825908c
@torchhound
Update 4.1.0 release date
f204362
@markpokornycos
installs ios-eventsource 4.0.2
35fe469
@markpokornycos
installs CocoaPods 1.7.2
872dc91
@markpokornycos
clears swift 5 update warning
a25e6ff
@markpokornycos
updates circle config to use xcode 10.2.1
ea1eb0f
@markpokornycos
advances version to 4.1.1
bbe700f
@markpokornycos
installs Nimble 8.0.2
3b49d6d
@markpokornycos
updates SwiftLint to 0.33.0
e1ebc1d
@torchhound
Merge branch 'master' into next-release
ff7b3b0
@torchhound
Update 4.1.1 release date
403aad9
@torchhound
Improved CHANGELOG 4.1.1 description
7da46cb
@torchhound
Made CHANGELOG 4.1.1 more consistent
419b138
@torchhound
Merge pull request #77 from launchdarkly/version_4.1.1
27e6b7e 
Prepare Version 4.1.1
@torchhound
Merge branch 'master' into next-release
802dff6
@torchhound
Merge branch 'master' into next-release
dfbb85f
@torchhound
4.1.2 release, updated version numbers and CHANGELOG
c5589c2
@torchhound
Made 4.1.2 CHANGELOG entry more descriptive
6c007f8
@torchhound
Merge branch 'master' into next-release
19e9764
@torchhound
Rebuilt Connection Status, added unit tests, fixed warnings
71b1a4e
@torchhound
Changed guard to equals in Dictionary extension, changed ConnectionIn…
63a0ad2 
…formation to struct
@torchhound
Fixed threading issues and reference semantics
7e0c447
@torchhound
Improved ConnectionInformation toString, fixed background behavior
6d942ef
@torchhound
Added network connectivity check, changed TimeIntervals to Optionals
13e3224
@torchhound
Improved background connection status behavior
8ee3fde
@torchhound
Changed ConnectionInformation description to computed property
05cd525
@torchhound
Merge pull request #78 from launchdarkly/jc/ch34534/connection-status-v2
b29f212 
Rebuilt Connection Status, added unit tests, fixed warnings
@torchhound
Added new identify method, updated swiftlint rules
eae3119
@torchhound
Made Identify actually change the user, fixed unit tests
b637c84
@torchhound
Removed unnecessary _user assignment
29891e6
@torchhound
Move swiftlint disable to LDClient, move user assignment into identif…
2d2ea9e 
…yInternal
@torchhound
Added private setOnline and go functions for identify
1d1996a
@torchhound
Forgot to replace go in guard with goIdentify
799b1bd
@torchhound
Copied user property unit tests for identify
ebc945a
@torchhound
Added optimization to not call setOnline when there is no completion …
d850196 
…and wasOnline is false
@torchhound
Testing identifyInternal change in IH
2834529
@torchhound
requested PR changes
1afaaea
@torchhound
Fixed convertCachedData call count, some PR feedback fixes
d34e4d6
@torchhound
Simplified unit tests, added comment about thread safety
e730d9d
@torchhound
Merge pull request #79 from launchdarkly/jc/ch40005/identify-method
bd0a4b8 
Add Identify method
@torchhound
Changed lastSuccessfulConnection to lastKnownFlagValidity, added on s…
b54ef8c 
…tream close listener
@torchhound
Fixed handler
b38bc22
@torchhound
Remove unnecessary import
e352876
@torchhound
Changed eventSource access level
5279281
@torchhound
Reset lastKnownFlagValidity to nil when we make a successful stream c…
7d9a3f0 
…onnection
@torchhound
Made comment about lastKnownFlagValidity having a value more clear
ad1d6b4
@torchhound
Changed guard let to if let in DarklyService EventSource extension
705ca57
@torchhound
Merge pull request #80 from launchdarkly/jc/connection-status-time-ch…
9d41357 
…ange

Changed lastSuccessfulConnection to lastKnownFlagValidity, added on s…
@torchhound
Updated README, CHANGELOG, and podspec for 4.2.0
0a29569
@torchhound
Merge branch 'master' into next-release
bca7a0d
@torchhound
[4.2.1] - 2019-11-15 (#81)
df2bc50 
* Added 4.2.1 changes including Dictionary fix and test and eventsource version bump

* Added Carthage build files

* Added attribution to CHANGELOG
@torchhound torchhound merged commit d166b83 into v4 Nov 15, 2019
@torchhound torchhound deleted the 4.2.1 branch November 15, 2019 19:35
keelerm84 pushed a commit that referenced this pull request May 4, 2022
@gwhelanLD
(V6) Bring back some ObjcLDUser attribute* constants (#198)
a0e04ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torchhound @markpokornycos