Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only import WatchKit if running on watchOS #183

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Only import WatchKit if running on watchOS #183

merged 1 commit into from
Jul 10, 2019

Conversation

ugiacoman
Copy link
Contributor

@ugiacoman ugiacoman commented Jul 10, 2019 •
edited
Loading

Problem

In Xcode 11, you cannot import WatchKit on iOS simulators.

Error:

"WatchKit" is not available when building for iOS Simulator. Consider using `#if !os(iOS)` to conditionally import this framework.

Solution

  • Conditionally import WatchKit if running on watchOS

Testing

  • Passes Tests
  • Runs on both Xcode 10.2 and Xcode 11

@torchhound
Copy link
Contributor

Hi @ugiacoman, thanks for putting in a PR! I'll do some testing on this and get back to you.

@marcelofabri marcelofabri mentioned this pull request Jul 10, 2019
Closed
@torchhound
Copy link
Contributor

Tested and LGTM!

@torchhound torchhound merged commit 43deb88 into launchdarkly:v4 Jul 10, 2019
@torchhound
Copy link
Contributor

torchhound commented Jul 11, 2019 •
edited
Loading

This is now available in the iOS Client 4.1.2 release, thanks again for the PR!

keelerm84 pushed a commit that referenced this pull request May 4, 2022
@gwhelanLD
Merge pull request #183 from launchdarkly/gw/sc-144831/ldavlue-for-ev…
b40e3d2 
…ent-pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugiacoman @torchhound