Prepare 4.1.0 release #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* installs new deviceModel into EnvironmentReporter and renames old deviceModel to deviceType * use CwSysCtl for macos model
Fix for concurrency bug in FlagStore
gwhelanLD
reviewed
Jun 19, 2019
| @@ -1,7 +1,7 @@ | |||
| Pod::Spec.new do |ld| | |||
|
|
|||
| ld.name = "LaunchDarkly" | |||
| ld.version = "4.0.0" | |||
| ld.version = "4.1.0" | |||
There was a problem hiding this comment.
What makes this a minor release rather than a patch? It looks like the deviceModel/deviceType changes are internal, but I might be wrong.
CHANGELOG.md
Outdated
| ## [4.1.0] - 2019-06-19 | ||
| ### Change | ||
| - Installs new `deviceModel` into `EnvironmentReporter` and renames old `deviceModel` to `deviceType` | ||
| - use `CwSysCtl` for macos model |
There was a problem hiding this comment.
Is this meant to be two separate entries? They seem related, but the CrSysCtl one is rather unclear on what it means.
gwhelanLD
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.1.0] - 2019-06-19
Change
deviceModelintoEnvironmentReporterand renames olddeviceModeltodeviceTypeCwSysCtlfor macos modelFixed