Subscribing to flag changes not calling handler post flag update. #252
Comments
Adarsha-KTC
changed the title
tanderson-ld
added a commit
that referenced
this issue
Aug 25, 2023
#252) Need to merge test harness changes before this will pass. **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/v6/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/213112/inconsistent-applicationname-and-applicationversionname-validation **Describe the solution you've provided** - Added sanitization logic to application info fields where spaces are now converted to hyphens. This is to help customers create values that will be accepted by our cloud infrasturcture. - Updated application info to support nullables. - Updated fallback logic to fallback to next source of application info if the applicationID is invalid. This invalid ID would be rejected by the cloud, so making that consistent. - Fixing bug in hashing to calulcate ld_application key where an omitted version would actually result in hash("myID:nil") when it should have been hash("myID:") **Describe alternatives you've considered** See: https://launchdarkly.atlassian.net/wiki/spaces/~63fb3c420d9b61193c23bde7/pages/2544828779/213112+-+Consistent+application+info+validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: