Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS streaming does not refresh on value change #201

Closed
Titozzz opened this issue Dec 4, 2019 · 6 comments
Closed

iOS streaming does not refresh on value change #201

Titozzz opened this issue Dec 4, 2019 · 6 comments
Labels

Comments

@Titozzz
Copy link

Titozzz commented Dec 4, 2019

Describe the bug
When updating a variation value, the new value does not trigger a refresh.

To reproduce
Update a variation value, your event listener does not get triggered
I think the issue comes from here: https://github.com/launchdarkly/ios-client-sdk/blob/v4/LaunchDarkly/LaunchDarkly/Service%20Objects/FlagChangeNotifier.swift#L161

Expected behavior
Same as on android, value updates should trigger the event listener.

SDK version
I'm using react-native sdk 2.0.3 with iOS SDK 4.3.0

@Titozzz
Copy link
Author

Titozzz commented Dec 4, 2019

Meanwhile I know the fix is not good but kindof working, I did this:

return !(oldFeatureFlag.matchesVariation(newFeatureFlag) && oldFeatureFlag.value as? String == newFeatureFlag.value as? String)

@torchhound
Copy link
Contributor

Hi @Titozzz the React Native SDK version 2.0.3 is only compatible with iOS SDK version 4.1.2. The use of 4.3.0 is undefined behavior. Please use the correct version and see if that fixes your issue.

@Titozzz
Copy link
Author

Titozzz commented Dec 5, 2019

@torchhound it does not, I've tried both versions, hence the fix I proposed above..

@torchhound torchhound added the bug label Dec 5, 2019
@torchhound
Copy link
Contributor

torchhound commented Dec 5, 2019

@Titozzz thank you for reporting this issue, it looks like this is a bug. We will remediate and release a new version soon. Filed as 58261.

@torchhound
Copy link
Contributor

Hi @Titozzz this bug was just fixed in version 4.3.2. Thanks again for reporting it!

@Titozzz
Copy link
Author

Titozzz commented Dec 27, 2019

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants