Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous access level #184

Closed
wqz-leo opened this issue Jul 10, 2019 · 2 comments
Closed

Ambiguous access level #184

wqz-leo opened this issue Jul 10, 2019 · 2 comments

Comments

@wqz-leo
Copy link

wqz-leo commented Jul 10, 2019

Is your feature request related to a problem? Please describe.

This initialiser is private, but the struct and properties are public. Therefore, this struct cannot be created from outside of this package, and those two properties are not accessible. There might be a reason of this, but from a developer point of view it's a bit confusing.

Describe the solution you'd like
Make initialiser public or struct and properties internal.

Describe alternatives you've considered
N/A

Additional context
N/A

@torchhound
Copy link
Contributor

Hi @wqz-leo, thanks for bringing this up! How are you using Minima? Are you using the struct directly or using the public field in the LDConfig class? Is your usecase what's defined in the migration guide or something different?

@wqz-leo
Copy link
Author

wqz-leo commented Jul 15, 2019

Hi @torchhound , sorry my bad, I was play around with the library and confused initially. Now I figured out the reason for this. Thanks for reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants