Fix podspec issues (#80)

* Fix warnings creatings issue for cocoapods * Try to include lint in circleCI * Fix lib lint * Try fixing lib lint * Try to fix lib lint * Fix spacing issues to validate yml
launchdarkly · Jan 4, 2017 · 6eb6132 · 6eb6132
1 parent 7d70fd0
commit 6eb6132
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/Darkly/LDClient.m b/Darkly/LDClient.m
@@ -286,7 +286,7 @@ -(void)userUpdated {
 
 // Notification handler for DataManager config flag update
 -(void)configFlagUpdated:(NSNotification *)notification {
-    NSString *keyValue = notification.userInfo;
+    NSString *keyValue = [notification.userInfo objectForKey:@"flagkey"];
     if (self.delegate && [self.delegate respondsToSelector:@selector(featureFlagDidUpdate:)]) {
         [self.delegate featureFlagDidUpdate:keyValue];
     }

diff --git a/Darkly/LDFlagConfigModel.h b/Darkly/LDFlagConfigModel.h
@@ -10,7 +10,7 @@
 
 @interface LDFlagConfigModel : NSObject <NSCoding>
 
-extern NSString * const kFeaturesJsonDictionaryKey;
+extern NSString * _Nullable  const kFeaturesJsonDictionaryKey;
 
 @property (nullable, nonatomic, strong) NSDictionary *featuresJsonDictionary;
 

diff --git a/Darkly/Models/LDDataManager.m b/Darkly/Models/LDDataManager.m
@@ -97,7 +97,7 @@ -(LDUserModel *)findUserWithkey: (NSString *)key {
 - (void)compareConfigForUser:(LDUserModel *)user withNewUser:(LDUserModel *)newUser {
     for (NSString *key in [[newUser.config dictionaryValue] objectForKey:kFeaturesJsonDictionaryKey]) {
         if(user == nil || ![[newUser.config configFlagValue:key] isEqual:[user.config configFlagValue:key]]) {
-            [[NSNotificationCenter defaultCenter] postNotificationName:kLDFlagConfigChangedNotification object:nil userInfo:key];
+            [[NSNotificationCenter defaultCenter] postNotificationName:kLDFlagConfigChangedNotification object:nil userInfo:[NSDictionary dictionaryWithObject:key forKey:kFlagKey]];
         }
     }
 }

diff --git a/circle.yml b/circle.yml
@@ -1,3 +1,7 @@
 machine:
-   xcode:
-     version: 8.1
+ xcode:
+  version: 8.1
+
+test:
+ post:
+  - pod lib lint