Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track TimeToFirstToken in LdAiConfigTracker #67

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: track TimeToFirstToken in LdAiConfigTracker #67

merged 3 commits into from
Jan 28, 2025

Conversation

moribellamy
Copy link
Contributor

No description provided.

@moribellamy moribellamy requested a review from keelerm84 January 23, 2025 00:29
@moribellamy moribellamy requested a review from a team as a code owner January 23, 2025 00:29
@moribellamy moribellamy changed the title track TimeToFirstToken in LdAiConfigTracker feat: track TimeToFirstToken in LdAiConfigTracker Jan 23, 2025
@moribellamy moribellamy requested a review from keelerm84 January 23, 2025 19:24
tanderson-ld
tanderson-ld approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tanderson-ld tanderson-ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the failure in the tests is due to microsoft releasing the next version of the workloads we use. I can try to dig into it as I was the last to touch that layer of this repo. What is your time frame on this change?

@moribellamy
Copy link
Contributor Author

I suspect the failure in the tests is due to microsoft releasing the next version of the workloads we use. I can try to dig into it as I was the last to touch that layer of this repo. What is your time frame on this change?

can we shoot for early next week?

should i hold of on submitting until the CI is fixed?

@tanderson-ld
Copy link
Contributor

Yeah I can try to take a look early next week. We do need to address them before this merges to help maintain the CI/CD

@tanderson-ld
Copy link
Contributor

Taking a look today.

@tanderson-ld tanderson-ld merged commit 875dba5 into main Jan 28, 2025
10 of 11 checks passed
@tanderson-ld tanderson-ld deleted the mori/ttft branch January 28, 2025 19:35
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
tanderson-ld pushed a commit that referenced this pull request Jan 28, 2025
@github-actions
chore(main): release LaunchDarkly.ServerSdk.Ai 0.6.0 (#69)
0bb6ab9 
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](LaunchDarkly.ServerSdk.Ai-v0.5.0...LaunchDarkly.ServerSdk.Ai-v0.6.0)
(2025-01-28)


### Features

* track TimeToFirstToken in LdAiConfigTracker
([#67](#67))
([875dba5](875dba5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanderson-ld tanderson-ld tanderson-ld approved these changes

@keelerm84 keelerm84 Awaiting requested review from keelerm84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moribellamy @tanderson-ld @keelerm84