This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
JS Client SDK: Add callout to use evaluationDetails option in variationDetail section #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@launchdarkly/docs-reviewers - as one of the JS SDK maintainers, this is correct from a technical standpoint. |
scribblingfox
approved these changes
Sep 17, 2020
scribblingfox
approved these changes
Sep 17, 2020
|
Hi @msiadak--thanks so much for this lil PR! Merging it in now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, while implementing some functionality to use
variationDetailcalls to examine and respond to flag evaluation reasons, I missed the requirement that you must set theevaluationReasonsoption to true fordetail.reasonto be populated in the JS Client SDK.This PR adds a callout to the docs reminding readers to enable that option if they wish to access Evaluation Reasons from the SDK.