Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Done trait, rename DbDone to DbOutcome #976

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Remove the Done trait, rename DbDone to DbOutcome #976

merged 2 commits into from
Jan 21, 2021

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jan 12, 2021 •
edited
Loading

As dicussed on Discord (discussion started here).

@jplatte jplatte force-pushed the del-done branch 5 times, most recently from b8aa0fb to ee93882 Compare January 12, 2021 12:44
@jplatte jplatte changed the title Remove the Done trait Remove the Done trait, rename DbDone to DbOutcome Jan 12, 2021
@jplatte jplatte mentioned this pull request Jan 14, 2021
Merged
@mehcode
Copy link
Member

mehcode commented Jan 21, 2021

After much deliberation, we decided to go with DbQueryResult to make this very obvious what it is - if a bit wordy.

Reasons:

  • Nearly every db library calls this type Result, SqlResult, or some variation on that
  • std has examples of XResult types not being Result<T, Error> aliases

@mehcode mehcode merged commit 08a76f4 into launchbadge:master Jan 21, 2021
@jplatte jplatte deleted the del-done branch January 21, 2021 10:03
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @mehcode