Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use let else statements in favor of macro #2213

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Use let else statements in favor of macro #2213

merged 1 commit into from
Feb 8, 2023

Conversation

OverHash
Copy link
Contributor

Uses the new let else statement released in Rust 1.65 in favor of a unwrap_or_else macro rule inlined to the code.

@abonander abonander changed the base branch from main to 0.7-dev February 4, 2023 00:48
@abonander
Copy link
Collaborator

@OverHash changed base to 0.7-dev, can you rebase please?

@OverHash
Copy link
Contributor Author

OverHash commented Feb 4, 2023

@abonander did I do it right? messed around a bit, might be running the wrong git commands 🙃

@OverHash
Copy link
Contributor Author

OverHash commented Feb 4, 2023

Just did another force push which might be more correct now. This should be based off 0.7-dev.

@abonander abonander merged commit 5d4bbd5 into launchbadge:0.7-dev Feb 8, 2023
@OverHash OverHash deleted the let-else branch February 8, 2023 22:29
abonander pushed a commit that referenced this pull request Feb 18, 2023
abonander pushed a commit that referenced this pull request Feb 21, 2023
Aandreba pushed a commit to Aandreba/sqlx that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants