Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gist support #173

Closed
nilbus opened this issue Apr 5, 2012 · 4 comments
Closed

Gist support #173

nilbus opened this issue Apr 5, 2012 · 4 comments

Comments

@nilbus
Copy link

nilbus commented Apr 5, 2012

Would you be interested in bringing gist support back? I'm willing to make it happen if you'll accept the feature.

@laullon
Copy link
Owner

laullon commented Apr 6, 2012

sure

@nilbus
Copy link
Author

nilbus commented Apr 6, 2012

Cool. I have gists working in SciMed/GitX, but your fork has diverged significantly from mine. I see in history.js:20 that showCommit gets sent data which is rendered as the commit markup, but I can't find where in the project that call to showCommit is happening. Could you clarify that for me? I need to add the "Gist it" button there, since the page content is not in history/index.html like it used to be.

@laullon
Copy link
Owner

laullon commented Apr 11, 2012

Can you try to make a "pull request"?

Germán Laullón
Web: http://www.laullon.com/

On Fri, Apr 6, 2012 at 6:42 AM, Edward Anderson
[email protected]
wrote:

Cool. I have gists working in SciMed/GitX, but your fork has diverged significantly from mine. I see in history.js:20 that showCommit gets sent data which is rendered as the commit markup, but I can't find where in the project that call to showCommit is happening. Could you clarify that for me? I need to add the "Gist it" button there, since the page content is not in history/index.html like it used to be.


Reply to this email directly or view it on GitHub:
#173 (comment)

@nilbus
Copy link
Author

nilbus commented May 6, 2012

Sure. I have some clean-up I want to do first with the github login interface. Once I find time to do that (in the next several weeks?), I'll submit a pull request that references this issue.

@nilbus nilbus closed this as completed May 6, 2012
jspiro pushed a commit to jspiro/gitx that referenced this issue Nov 26, 2021
Ensure the commitMessageView.typingAttributes
dictionary is not nil before setting properties on it.

Fixes laullon#173
Fixes regression from a118470 on 10.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants