-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PandasCursor incorrectly converts some strings as nulls #118
Comments
I checked it in the following branch, but I can't judge NULL and empty string well. 😢 |
laughingman7743
added a commit
that referenced
this issue
Aug 2, 2020
laughingman7743
added a commit
that referenced
this issue
Aug 2, 2020
laughingman7743
added a commit
that referenced
this issue
Aug 10, 2020
Fix empty & null string conversion with PandasCursor (refs #118)
I got the opposite error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With pyathena 1.10.0 and pandas 1.0.0:
Expected output:
Actual output:
Underlying reason: The csv file on AWS that PandasCursor uses looks like this
in https://github.com/laughingman7743/PyAthena/blob/master/pyathena/result_set.py#L445 the call to
read_csv
should has at least something likena_values=['']
andkeep_default_na=False
.The problem is how to get pandas
read_csv
to treat a quoted empty string as the empty string, and an unquoted empty string as a null (in my opinion "quoting=1" (ALL) should do it, but it doesn't).The text was updated successfully, but these errors were encountered: