-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(world): add module gas reports for setting many keys #771
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KeysWithValue
gas reports for 10 and 100 keysKeysWithValue
gas reports for setting many keys
KeysWithValue
gas reports for setting many keys
|
unclear to me atm why the gas report step fails in the checks but work locally |
alright seems like setting 10k keys was too much for the CI |
Unfortunately this change increases the time for the Because of that I'll close this PR for now, but we can look at it for reference when optimizing the We should also find a way to run these gas reports more efficiently, the |
Looks like gas reports are the bulk of this: I'm hoping we can soon move over to Vulcan gas reports (or pull in the same strategy) once they land, which will mean the gas reports and tests are run at the same time: nomoixyz/vulcan#104 |
Tests setting 10, 100, 1000,
10000records withKeysInTable
andKeysWithValue
.