refactor: normalize vite configs, use tsx for store/world scripts #655
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dk1a
force-pushed
the
dk1a/separate-generators-cleanup
branch
from
7d6aaef to
6f2f434
Compare
dk1a
changed the title
holic
reviewed
Apr 20, 2023
| "build:abi": "forge build --out abi --skip test script", | ||
| "build:codegen": "node ./dist/tablegen.js", | ||
| "build:codegen": "tsx ./ts/scripts/tablegen.ts", |
There was a problem hiding this comment.
yay! this resolves my comment about the script order
holic
approved these changes
Apr 20, 2023
just to clarify, is this just I imagine we'll import some common stuff into client code, so just wanna make sure this big bump is isolated to just codegen. |
yes, forge for example is unchanged (much less than 1000kB) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common's bundle size from ~50kB to ~1000kB. Probably not much of an issue since it's nodeside. Also movedbuild:jsback to the end.modules.d.tswith prettier plugin stuff, but they're still required in the downstream packages unfortunately