feat: use viem when creating burner wallet #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holic
commented
Apr 3, 2023
| const cachedPrivateKey = localStorage.getItem(cacheKey); | ||
| const subject = cachedPrivateKey | ||
| const subject = isHex(cachedPrivateKey) |
There was a problem hiding this comment.
are we okay with this being a destructive action? it used to just add a burner wallet if no value was set for the given cache key, but now it checks if it's hex and will recreate one if not
which means if someone has a different value stored at this key, we will end up overriding it with a new burner wallet private key
alternatively, we could just throw/bail if we detect a non-hex value at this cache key
There was a problem hiding this comment.
I think throwing if it's an invalid value would be better bc it would tell users who are trying to override the burner wallet (but put an invalid value) why it fails
alvrs
previously approved these changes
Apr 4, 2023
alvrs
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #582