feat(cli): allow static arrays as abi types in store config and tablegen #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
previously approved these changes
Mar 27, 2023
Comment on lines
+13
to
+17
| // When type inference sees multiple uses of 1 generic, it can only guess | ||
| // which of those are supposed to define the generic (and it will be wrong in complex situations). | ||
| // This helper explicitly makes a type that's dependent on some generic, | ||
| // and will not be inferred as the generic's definition. | ||
| export type AsDependent<T> = T extends infer P ? P : never; |
There was a problem hiding this comment.
check out parseStoreConfig.test-d.ts
Comment on lines
+58
to
+59
| // WARNING: ensure this still works if changing major solidity versions! | ||
| // (the memory layout for static arrays may change) |
There was a problem hiding this comment.
How can we remind ourselves of this when changing major solidity versions? Maybe a comment in cli's foundry.toml?
alvrs
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that schema types are strings of abi types, I can make e.g.
uint32[2]just work, without user typesAlso added some more tests
An annoying regression here is a bunch of
function mutability can be restricted to purewarnings.Memory.copyuses identity precompile, which forcesview. And detecting which vars use such memory copying is a lot of needless complexity I'd rather avoid.This can be solved by changing
Memory.copy(would likely cost more gas), or generalizingTightCoderto be usable directly for static arrays (would sidestep the need for copying altogether).Regardless, for
Memory.copyit would be best to use the native MCOPY if it ever happens: https://eips.ethereum.org/EIPS/eip-5656related: ethereum/solidity#12127
Also fixed a type inference bug which would happen in some complex configs with multiple user types