feat(store-sync): recs sync adapter #3486
Conversation
🦋 Changeset detectedLatest commit: 73778d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -5,6 +5,7 @@ export type InternalComponents = ReturnType<typeof defineInternalComponents>; | |||
|
|
|||
| export function defineInternalComponents(world: World) { | |||
| return { | |||
| /** @deprecated */ | |||
| RegisteredTables: defineComponent<{ table: Type.T }, Metadata, Table>( | |||
There was a problem hiding this comment.
was torn on what to do with this! this is no longer needed as part of the storage adapter because we now use the component.metadata.table for things like schemas
I removed the populating of this table/component from the storage adapter and deprecated this (rather than removed) because it used to be part of the components return type of syncToRecs
I could just remove because it was considered "internal" and doesn't appear to be used: https://github.com/search?q=RegisteredTables+%28path%3A*.ts+OR+path%3A*.tsx%29+-org%3Alatticexyz&type=code
thoughts?
|
|
||
| export type StoreComponentMetadata = Metadata & { | ||
| componentName: string; | ||
| tableName: string; | ||
| table: Table; | ||
| // TODO: migrate to store's KeySchema/ValueSchema | ||
| keySchema: KeySchema; | ||
| valueSchema: ValueSchema; |
There was a problem hiding this comment.
these aren't technically needed anymore but was also worried about breaking downstream usage by removing
https://github.com/search?q=%28%22metadata.keySchema%22+OR+%22metadata.valueSchema%22%29+%28path%3A*.ts+OR+path%3A*.tsx%29+-org%3Alatticexyz&type=code
pulled out of #3485