Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-sync): apply logs as one stash update #3411

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

holic
Copy link
Member

@holic holic commented Jan 6, 2025

pulled out of #3240

like zustand storage adapter, this applies all logs as one applyUpdates operation, resulting in one subscriber emission instead of one per log

@holic holic requested a review from alvrs as a code owner January 6, 2025 10:15
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 16f0504

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

return async function storageAdapter({ logs }: StorageAdapterBlock): Promise<void> {
const pendingRecords: Record<string, PendingStashUpdate> = {};
const updates: PendingStashUpdate[] = [];
Copy link
Member Author

@holic holic Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a little weird to do all this tracking here, might be nice if in the future stash would export a util for this like

mutate(({ getRecord, setRecord }) => {
  getRecord(...);
  setRecord(...);
});

where it internally keeps track of the pending updates/mutations and applies them all at the end of the function execution

@holic holic merged commit d368857 into main Jan 6, 2025
15 checks passed
@holic holic deleted the holic/stash-storage-adapter branch January 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants