Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): improve memory copy #3400

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Dec 21, 2024

Memory.copy behavior is unchanged (I changed dev comment however to better reflect mcopy's description, rather than the previous workaround)
Only the relevant bytecode is changing (which I think what getStoreLogs.test.ts is about)

I wanted to use mcopy from the beginning, but back in 2023 that eip wasn't implemented yet, so the lengthy code was a less efficient workaround
With solidity 0.8.24 the opcode is usable

Copy link

changeset-bot bot commented Dec 21, 2024

🦋 Changeset detected

Latest commit: e3721e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/react Patch
@latticexyz/stash Patch
@latticexyz/store-consumer Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dk1a
Copy link
Contributor Author

dk1a commented Dec 21, 2024

What do you do with store logs? The remaining failing tests seem unrelated and happen for me even on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant