Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gas-report): include contract name in file of output #3317

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

holic
Copy link
Member

@holic holic commented Oct 22, 2024

Once we started testing with multiple contracts in one file, we were seeing our gas reports jump around a lot, which may mean foundry/forge test output is only deterministic within (filename, contract name) rather than just (filename).

Fixed this by adding contract name to the file output, which more closely matches build artifacts anyway. I don't love the name file now that it has the contract name but 🤷‍♂️ not sure if we should change this also.

Also rearranged the package a bit to match other packages.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: cbc1e4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@latticexyz/gas-report Patch
@latticexyz/cli Patch
@latticexyz/schema-type Patch
@latticexyz/store Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title fix(gas-report): deterministic/sorted output fix(gas-report): add contract name to file output Oct 22, 2024
@holic holic changed the title fix(gas-report): add contract name to file output fix(gas-report): add contract name to file in output Oct 22, 2024
@holic holic changed the title fix(gas-report): add contract name to file in output fix(gas-report): include contract name to file in output Oct 22, 2024
@holic holic changed the title fix(gas-report): include contract name to file in output fix(gas-report): include contract name in file of output Oct 22, 2024
@holic holic merged commit d5c2700 into main Oct 22, 2024
13 checks passed
@holic holic deleted the holic/gas-report-deterministic-output branch October 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant