-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gas-report): include contract name in file of output #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbc1e4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
fix(gas-report): deterministic/sorted output
fix(gas-report): add contract name to file output
Oct 22, 2024
holic
changed the title
fix(gas-report): add contract name to file output
fix(gas-report): add contract name to file in output
Oct 22, 2024
holic
changed the title
fix(gas-report): add contract name to file in output
fix(gas-report): include contract name to file in output
Oct 22, 2024
holic
changed the title
fix(gas-report): include contract name to file in output
fix(gas-report): include contract name in file of output
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we started testing with multiple contracts in one file, we were seeing our gas reports jump around a lot, which may mean foundry/forge test output is only deterministic within (filename, contract name) rather than just (filename).
Fixed this by adding contract name to the
file
output, which more closely matches build artifacts anyway. I don't love the namefile
now that it has the contract name but 🤷♂️ not sure if we should change this also.Also rearranged the package a bit to match other packages.