Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): adjust deploy order #3222

Merged
merged 2 commits into from
Sep 23, 2024
Merged

refactor(cli): adjust deploy order #3222

merged 2 commits into from
Sep 23, 2024

Conversation

holic
Copy link
Member

@holic holic commented Sep 23, 2024

deploy world then user contracts instead of the other way around, to keep from spending gas on contract deploys in cases where world deploy fails

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 1d1660b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/cli Patch
@latticexyz/world-modules Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review September 23, 2024 13:56
@holic holic requested a review from alvrs as a code owner September 23, 2024 13:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@@ -62,9 +61,29 @@ export async function deploy({
}: DeployOptions): Promise<WorldDeploy> {
const deployerAddress = initialDeployerAddress ?? (await ensureDeployer(client));

await ensureWorldFactory(client, deployerAddress, config.deploy.upgradeableWorldImplementation);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this happens inside deployWorld, so no need to double up on it here (or do it when a custom world is used)

@holic holic merged commit 9d990b5 into main Sep 23, 2024
12 checks passed
@holic holic deleted the holic/deploy-order branch September 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants