Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): world address cli option as hex #3155

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Conversation

karooolis
Copy link
Contributor

@karooolis karooolis commented Sep 9, 2024

Migrated to yargs in order to correctly interpret worldAddress CLI option as a hexadecimal value. minimist misinterpreted it as a number, and the patch could not be reliably published as part of the package.

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: d46353e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/explorer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karooolis karooolis changed the title fix(explorer): refactor to yargs for cli fix(explorer): world address cli option as hex Sep 9, 2024
@karooolis karooolis marked this pull request as ready for review September 9, 2024 18:13
@karooolis karooolis merged commit b9c61a9 into main Sep 10, 2024
14 checks passed
@karooolis karooolis deleted the kumpis/minimist-to-yargs branch September 10, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants