Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve type benches with baseline + .ts files, avoiding build #2988

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

ssalbdivad
Copy link
Collaborator

@ssalbdivad ssalbdivad commented Jul 29, 2024

While investigating the type performance issues that led to wevm/viem#2557, I made some improvements to the local type benchmarks.

The new "baseline expression" allows them to be run accurately directly from .ts files and gives a much better linear representation of the cost of each bench (note that the scaling between 1 table and 5 tables is close to linear).

Also updated @arktype dependencies to the latest version and new @ark scope.

@ssalbdivad ssalbdivad requested review from alvrs and holic as code owners July 29, 2024 21:19
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 0b91caf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -40,7 +40,7 @@
"test:ci": "pnpm run test"
},
"dependencies": {
"@arktype/util": "0.0.40",
"@ark/util": "catalog:",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great feature! I figured I'd use it since I was updating @ark/util anyways, but you could migrate to this for all packages you share as non-dev dependencies across multiple packages.

Having multiple package versions can cause lots of problems, so the centralization is super valuable.

@holic holic merged commit 791736c into latticexyz:main Jul 30, 2024
13 of 14 checks passed
@holic holic mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants