-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve type benches with baseline + .ts files, avoiding build #2988
Conversation
|
@@ -40,7 +40,7 @@ | |||
"test:ci": "pnpm run test" | |||
}, | |||
"dependencies": { | |||
"@arktype/util": "0.0.40", | |||
"@ark/util": "catalog:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great feature! I figured I'd use it since I was updating @ark/util
anyways, but you could migrate to this for all packages you share as non-dev dependencies across multiple packages.
Having multiple package versions can cause lots of problems, so the centralization is super valuable.
While investigating the type performance issues that led to wevm/viem#2557, I made some improvements to the local type benchmarks.
The new "baseline expression" allows them to be run accurately directly from
.ts
files and gives a much better linear representation of the cost of each bench (note that the scaling between 1 table and 5 tables is close to linear).Also updated
@arktype
dependencies to the latest version and new@ark
scope.