Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store,world): simplify table shorthands #2969

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

holic
Copy link
Member

@holic holic commented Jul 23, 2024

We initially thought it would be cool to treat table shorthands as more of a plugin/extension/wrapper around the config, but its been getting in the way while building out multi-namespace support (#2968), because there's now another deeply-nested place where tables can be defined and would need to be mapped/wrapped.

Since table shorthands are a fairly core part of the MUD config, we decided it was fine to bake this in directly and reduce overhead of this feature.

We'll find other ways to play around with config plugins/extensions/wrappers in the future.

Note that this deviates from our standard resolveX naming and uses expandX, mostly to differentiate this as an intermediate step and not a final step, where all other resolveX methods give you ~final output.

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 043480b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/store Patch
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
mock-game-contracts Patch
ts-benchmarks Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title wip make table shorthand native refactor(store,world): simplify shorthands Jul 23, 2024
@holic holic changed the title refactor(store,world): simplify shorthands refactor(store,world): simplify table shorthands Jul 23, 2024
@holic holic marked this pull request as ready for review July 23, 2024 19:04
@holic holic requested a review from alvrs as a code owner July 23, 2024 19:04
@holic holic merged commit fb1cfef into main Jul 24, 2024
13 checks passed
@holic holic deleted the holic/table-shorthand branch July 24, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants