-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(store,world): simplify table shorthands #2969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 043480b The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
wip make table shorthand native
refactor(store,world): simplify shorthands
Jul 23, 2024
holic
changed the title
refactor(store,world): simplify shorthands
refactor(store,world): simplify table shorthands
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially thought it would be cool to treat table shorthands as more of a plugin/extension/wrapper around the config, but its been getting in the way while building out multi-namespace support (#2968), because there's now another deeply-nested place where tables can be defined and would need to be mapped/wrapped.
Since table shorthands are a fairly core part of the MUD config, we decided it was fine to bake this in directly and reduce overhead of this feature.
We'll find other ways to play around with config plugins/extensions/wrappers in the future.
Note that this deviates from our standard
resolveX
naming and usesexpandX
, mostly to differentiate this as an intermediate step and not a final step, where all otherresolveX
methods give you ~final output.