Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: stash state lib #2944

Draft
wants to merge 121 commits into
base: main
Choose a base branch
from
Draft

WIP: stash state lib #2944

wants to merge 121 commits into from

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jul 15, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8c97a79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic reviewed Jul 17, 2024
View reviewed changes
packages/zustand-query/src/store.test.ts Outdated
/**
* A Record is one row of the table. It includes both the key and the value.
*/
type Record = { [field: string]: number | string | bigint | number[] | string[] | bigint[] };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also boolean and boolean[]

and beware that Record conflicts with the TS native Record

I think I've used Row or TableRecord in other areas

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good points!

@alvrs alvrs changed the title WIP: state lib benchmarks WIP: state lib Jul 17, 2024
@alvrs alvrs force-pushed the alvrs/zustand-query branch from 7282820 to ea3e66e Compare July 22, 2024 16:05
@alvrs alvrs force-pushed the alvrs/zustand-query branch 2 times, most recently from 7282820 to aba18e3 Compare July 22, 2024 19:39
@holic holic mentioned this pull request Aug 15, 2024
Closed
@alvrs alvrs mentioned this pull request Aug 15, 2024
Merged
@holic holic changed the title WIP: state lib WIP: stash state lib Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvrs @holic @Kooshaba