fix(cli,world): resolve table by just name #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 77d9e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
commented
May 21, 2024
| @@ -11,3 +11,5 @@ export * from "../encodeSystemCallsFrom"; | |||
| export * from "../actions/callFrom"; | |||
|
|
|||
| export * from "../callWithSignatureTypes"; | |||
|
|
|||
| export { resolveTableId, resolveWithContext } from "../config/v2/dynamicResolution"; | |||
There was a problem hiding this comment.
I am intentionally exporting resolveTableId in the internal bundle for now as I want to reconsider the API before we make it concrete.
holic
commented
May 21, 2024
|
|
||
| export type DynamicResolution = { | ||
| type: DynamicResolutionType; | ||
| // TODO: add systemAddress support | ||
| type: "tableId"; |
There was a problem hiding this comment.
this is an internal thing and changing this to strings instead of enums leads to better errors in the resolveWithContext function
alvrs
reviewed
May 21, 2024
| } | ||
| if (tableEntries.length > 1) { | ||
| throw new Error( | ||
| `Found more than one table with name "${input.input}". Try using one of the following table names instead: ${tableEntries.map(([tableName]) => tableName).join(", ")}`, |
alvrs
previously approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveTableId(or specifically the context passed intoresolveWithContext) changed slightly in #2803 where we started using namespaced table names, which broke some previous usages of just table names without a namespace. This adds back in support for just table names, with an error thrown if we can't resolve the table due to collisions (with an actionable error message to quickly resolve).We had set up a new
resolveTableIdwith the new config but never used it/exported it, so this also fixes that and removes the long-deprecated one as well as the now-unused v1 modules config.