Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump to node 18.20.2, pnpm 9.1.1 #2831

Merged
merged 7 commits into from
May 15, 2024
Merged

build: bump to node 18.20.2, pnpm 9.1.1 #2831

merged 7 commits into from
May 15, 2024

Conversation

holic
Copy link
Member

@holic holic commented May 15, 2024

addresses part of #2826 and maybe fixes vite process hanging due to anvil.js

to catch up your local environment

# install the node version in .nvmrc
nvm install
# use the node version in .nvmrc
nvm use
# install the pnpm version we use
npm install -g [email protected]

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 4d78642

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
create-mud Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title feat: bump node 18, pnpm 9 feat: bump to node 18.20.2, pnpm 9 May 15, 2024
@@ -5,8 +5,6 @@ runs:
steps:
- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8.x
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will default to the packageManager version in package.json

@@ -31,7 +31,7 @@ RUN curl -L https://foundry.paradigm.xyz/ | bash && \
# pnpm
ENV PNPM_HOME="/pnpm"
ENV PATH="${PATH}:${PNPM_HOME}"
RUN npm install pnpm@8 --global && pnpm --version
RUN npm install pnpm@9.1.1 --global && pnpm --version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this would install from the packageManager version so we don't have to redefine here but unclear how to do that

@holic holic changed the title feat: bump to node 18.20.2, pnpm 9 build: bump to node 18.20.2, pnpm 9 May 15, 2024
@holic holic marked this pull request as ready for review May 15, 2024 10:20
@holic holic requested review from ludns, qbzzt, alvrs and yonadaa as code owners May 15, 2024 10:20
@holic holic changed the title build: bump to node 18.20.2, pnpm 9 build: bump to node 18.20.2, pnpm 9.1.1 May 15, 2024
alvrs
alvrs previously approved these changes May 15, 2024
@holic holic merged commit 63e5d2d into main May 15, 2024
13 checks passed
@holic holic deleted the holic/bump-node-18 branch May 15, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants