Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cli faucet command and services package #2811

Merged
merged 6 commits into from
May 14, 2024
Merged

Conversation

holic
Copy link
Member

@holic holic commented May 10, 2024

  • remove broken mud faucet command
  • remove services package (was only around while the faucet command was around)
  • remove faucet usages from templates

I considered replacing the faucet command with something that uses the new faucet package, but wanna reconsider its API first

for templates, we'll soon replace burner accounts with account kit

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: b0ea888

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@latticexyz/cli Patch
create-mud Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alvrs
alvrs previously approved these changes May 14, 2024
@holic holic force-pushed the holic/remove-faucet branch from 6202194 to b1dca1c Compare May 14, 2024 15:55
@holic holic marked this pull request as ready for review May 14, 2024 16:25
@holic holic requested review from ludns, qbzzt and yonadaa as code owners May 14, 2024 16:25
@holic holic merged commit 4a61a12 into main May 14, 2024
12 checks passed
@holic holic deleted the holic/remove-faucet branch May 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants